book_add.php does not allow search in other servers when found in native

[David Everly]

Hi,

It seems that when using book_add.php, (Emilda 1.2.2.1) if search finds
something in Native, it does not allow searching other Servers.

http://demo.emilda.org/nightly also is working this way (as of today).

I think if the results from Native are not what the user wanted, then he
should be able to continue searching other Servers.

Thanks,
Dave.
--
Encrypted Mail Preferred:
Key ID: 8527B9AF
Key Fingerprint: E1B6 40B6 B73F 695E 0D3B 644E 6427 DD74 8527 B9AF
Information: http://www.gnupg.org/

ASCII ribbon campaign:
() against HTML email
/\ against Microsoft attachments
Information: http://www.expita.com/nomime.html

[Erik Berglund]

Post by David Everly
Hi,
It seems that when using book_add.php, (Emilda 1.2.2.1) if search finds
something in Native, it does not allow searching other Servers.
http://demo.emilda.org/nightly also is working this way (as of today).
I think if the results from Native are not what the user wanted, then he
should be able to continue searching other Servers.
Thanks,
Dave.

True, book add limits searching to Native if it finds something there.
This is ok when searching by ISBN since it will keep the database sane
(no duplicate records), but it is fatal when searching by other
criteria. We will fix this on cvs at least.

Regards,

[David Everly]

Post by Erik Berglund

Post by David Everly
Hi,
It seems that when using book_add.php, (Emilda 1.2.2.1) if search finds
something in Native, it does not allow searching other Servers.
http://demo.emilda.org/nightly also is working this way (as of today).
I think if the results from Native are not what the user wanted, then he
should be able to continue searching other Servers.
Thanks,
Dave.

True, book add limits searching to Native if it finds something there.
This is ok when searching by ISBN since it will keep the database sane
(no duplicate records),

I would prefer that a limitation like this be done before insert to the
database and not be a hidden limitation on searching itself. In other
words, searching should be only limited by the search criteria entered
by a user and by servers configured by the administrator.

The attempt to insert a record is an appropriate place for duplicate
checking. And since any of the fields could be altered by the user
prior to this insert, it is the only place such a check becomes
relevant.

Post by Erik Berglund
but it is fatal when searching by other criteria. We will fix this on
cvs at least.

Thanks :)
--
Encrypted Mail Preferred:
Key ID: 8527B9AF
Key Fingerprint: E1B6 40B6 B73F 695E 0D3B 644E 6427 DD74 8527 B9AF
Information: http://www.gnupg.org/

ASCII ribbon campaign:
() against HTML email
/\ against Microsoft attachments
Information: http://www.expita.com/nomime.html

[David Everly]

Post by Erik Berglund

Post by David Everly
Hi,
It seems that when using book_add.php, (Emilda 1.2.2.1) if search finds
something in Native, it does not allow searching other Servers.
http://demo.emilda.org/nightly also is working this way (as of today).
I think if the results from Native are not what the user wanted, then he
should be able to continue searching other Servers.
Thanks,
Dave.

True, book add limits searching to Native if it finds something there.
This is ok when searching by ISBN since it will keep the database sane
(no duplicate records), but it is fatal when searching by other
criteria. We will fix this on cvs at least.

I think I have a patch that fixes this. See attached.
--
Encrypted Mail Preferred:
Key ID: 8527B9AF
Key Fingerprint: E1B6 40B6 B73F 695E 0D3B 644E 6427 DD74 8527 B9AF
Information: http://www.gnupg.org/

ASCII ribbon campaign:
() against HTML email
/\ against Microsoft attachments
Information: http://www.expita.com/nomime.html

[Erik Berglund]

Post by David Everly

Post by Erik Berglund

Post by David Everly
Hi,
It seems that when using book_add.php, (Emilda 1.2.2.1) if search finds
something in Native, it does not allow searching other Servers.
http://demo.emilda.org/nightly also is working this way (as of today).
I think if the results from Native are not what the user wanted, then he
should be able to continue searching other Servers.
Thanks,
Dave.

True, book add limits searching to Native if it finds something there.
This is ok when searching by ISBN since it will keep the database sane
(no duplicate records), but it is fatal when searching by other
criteria. We will fix this on cvs at least.

I think I have a patch that fixes this. See attached.

Patch applied and committed, thanks! We'll probably have to change
book_add behavior in the future since array pointer hopping is perhaps
not the best way to do this.

Regards,